Update basic-v16-webpack demo to shakapacker 9.0.0.beta.5

[justin808]

Summary

• Updated basic-v16-webpack demo to use shakapacker 9.0.0.beta.5 instead of GitHub reference
• Fixed .new-demo-versions to use proper version specifier instead of GitHub ref
• Applied rubocop auto-fixes for string literal style

Changes

• Gemfile: Changed from "~> 9.3.beta.5", github: "shakacode/shakapacker" to '~> 9.0.0.beta.5'
• package.json: Changed from "github:shakacode/shakapacker" to "9.0.0-beta.5"
• .new-demo-versions: Changed from "github:shakacode/shakapacker" to "~> 9.0.0.beta.5"
• Updated lock files for both Ruby and npm

Test plan

• Linting passes (rubocop)
• Pre-commit and pre-push hooks pass
• Basic-v16-webpack demo runs successfully

🤖 Generated with Claude Code

[coderabbitai]

Warning

Rate limit exceeded

@justin808 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 8850f2f and db8a1ce.

⛔ Files ignored due to path filters (2)

• demos/basic-v16-webpack/Gemfile.lock is excluded by !**/*.lock
• demos/basic-v16-webpack/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (35)

• .new-demo-versions (1 hunks)
• demos/basic-v16-webpack/Gemfile (1 hunks)
• demos/basic-v16-webpack/Rakefile (1 hunks)
• demos/basic-v16-webpack/app/controllers/hello_world_controller.rb (1 hunks)
• demos/basic-v16-webpack/app/mailers/application_mailer.rb (1 hunks)
• demos/basic-v16-webpack/bin/brakeman (1 hunks)
• demos/basic-v16-webpack/bin/bundle (5 hunks)
• demos/basic-v16-webpack/bin/dev (1 hunks)
• demos/basic-v16-webpack/bin/rails (1 hunks)
• demos/basic-v16-webpack/bin/rake (1 hunks)
• demos/basic-v16-webpack/bin/rubocop (1 hunks)
• demos/basic-v16-webpack/bin/setup (2 hunks)
• demos/basic-v16-webpack/bin/shakapacker (1 hunks)
• demos/basic-v16-webpack/bin/shakapacker-dev-server (1 hunks)
• demos/basic-v16-webpack/bin/thrust (1 hunks)
• demos/basic-v16-webpack/config.ru (1 hunks)
• demos/basic-v16-webpack/config/application.rb (1 hunks)
• demos/basic-v16-webpack/config/boot.rb (1 hunks)
• demos/basic-v16-webpack/config/environment.rb (1 hunks)
• demos/basic-v16-webpack/config/environments/development.rb (3 hunks)
• demos/basic-v16-webpack/config/environments/production.rb (4 hunks)
• demos/basic-v16-webpack/config/environments/test.rb (2 hunks)
• demos/basic-v16-webpack/config/initializers/assets.rb (1 hunks)
• demos/basic-v16-webpack/config/initializers/cypress_on_rails.rb (1 hunks)
• demos/basic-v16-webpack/config/initializers/react_on_rails.rb (3 hunks)
• demos/basic-v16-webpack/config/puma.rb (1 hunks)
• demos/basic-v16-webpack/config/routes.rb (1 hunks)
• demos/basic-v16-webpack/e2e/playwright/app_commands/activerecord_fixtures.rb (1 hunks)
• demos/basic-v16-webpack/e2e/playwright/app_commands/clean.rb (2 hunks)
• demos/basic-v16-webpack/e2e/playwright/app_commands/log_fail.rb (2 hunks)
• demos/basic-v16-webpack/e2e/playwright/app_commands/scenarios/basic.rb (1 hunks)
• demos/basic-v16-webpack/e2e/playwright/e2e_helper.rb (2 hunks)
• demos/basic-v16-webpack/lib/tasks/e2e.rake (1 hunks)
• demos/basic-v16-webpack/package.json (1 hunks)
• demos/basic-v16-webpack/test/test_helper.rb (1 hunks)

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch justin808/shakapacker-9-beta-5

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

PR Review: Update basic-v16-webpack demo to shakapacker 9.0.0.beta.5

Summary

This PR transitions the basic-v16-webpack demo from using a GitHub reference for shakapacker to the published beta version 9.0.0.beta.5. The changes are well-structured and consistent.

---

✅ Code Quality & Best Practices

Strengths:

• Consistent style updates: RuboCop auto-fixes applied uniformly across all Ruby files, converting double quotes to single quotes per Ruby style guide
• Proper version specifier: Changed from GitHub reference to semantic versioning (~> 9.0.0.beta.5), which is more stable and appropriate for demos
• Lock file consistency: Both Gemfile.lock and package-lock.json properly updated to reflect dependency changes
• .new-demo-versions alignment: Updated the template configuration to match, ensuring future demos use the correct version

Minor observation:

• The version change in Gemfile went from ~> 9.3.beta.5 (GitHub) to ~> 9.0.0.beta.5 (published). This version number decrease (9.3 → 9.0) suggests the GitHub branch was ahead of the published beta. This is intentional and correct for using published releases.

---

🐛 Potential Issues

Critical - Test Plan Incomplete:
The PR description shows the test plan item "Basic-v16-webpack demo runs successfully" is unchecked. This is concerning because:

1. This is a dependency version change that could introduce breaking changes
2. The demo should be verified to work before merging
3. Version incompatibilities could break the demo for users

Recommendation: Please run the demo and verify:

cd demos/basic-v16-webpack
bundle install
npm install
bin/setup
bin/dev
# Visit http://localhost:3000/hello_world and confirm it works

Version alignment concern:

• Gemfile.lock shows shakapacker version is now 9.0.0 (not 9.0.0.beta.5)
• This suggests the published version might be 9.0.0 rather than 9.0.0.beta.5
• Please verify the correct version is actually published to RubyGems and npm

---

🔒 Security Concerns

No security issues identified:

• Dependencies upgraded to published versions (more trustworthy than GitHub refs)
• No sensitive data in changes
• Lock files properly updated (reduces supply chain risk)

---

⚡ Performance Considerations

Positive impacts:

• Using published gem versions enables better caching in CI/CD
• Eliminates GitHub API rate limiting issues during bundle install
• Faster installation compared to GitHub references

No negative impacts expected - this is a dependency version update without code changes.

---

🧪 Test Coverage

Current state:

• ✅ Linting passes (rubocop) - confirmed in test plan
• ✅ Pre-commit and pre-push hooks pass - confirmed in test plan
• ❌ Demo functionality not verified - needs to be completed

Recommendations:

1. Complete the test plan - run the demo and confirm it works
2. CI validation - if this repo has CI, ensure it runs against this PR
3. Consider adding a smoke test - automated test that verifies the demo starts successfully

---

📝 Additional Notes

Dependency version in package.json:
The npm package uses exact version 9.0.0-beta.5 while the Ruby gem uses pessimistic constraint ~> 9.0.0.beta.5. This is fine since:

• npm doesn't need the ~> operator (uses semantic versioning differently)
• The versions match semantically

RuboCop changes:
All the quote style changes (double → single) are cosmetic improvements that follow Ruby community standards. These don't affect functionality but improve consistency.

---

🎯 Verdict

Conditional approval - the code changes look good, but please:

1. ✅ Complete the test plan - verify the demo runs successfully
2. ✅ Verify version numbers - confirm 9.0.0.beta.5 is the correct published version
3. ✅ Document any breaking changes - if the version upgrade requires any configuration changes

Once the demo is confirmed working, this PR is ready to merge. The changes are well-structured and follow best practices for dependency management.

---

Review generated with attention to code quality, security, performance, and test coverage.