Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

46974426 - pull request for merging 2d UNet into PatternAnalysis-2024 topic recognition branch #138

Open
wants to merge 28 commits into
base: topic-recognition
Choose a base branch
from

Conversation

robert123654
Copy link

Dear Shakes,

Please review my contribution to the PatternAnalysis-2024 repository and provide feedback if not appropriate for merging.

Thanks,

Robert

Robert Slomka added 28 commits October 22, 2024 15:25
…nction added to handle images that are not 246*128
@yexincheng
Copy link
Collaborator

This is an initial inspection, no action is required at this point

  1. Solves problem: The final DICE score on validaiton set is around 0.998 from images/50Epoc_validation_score.png. Training loss is provided. Prediction figures were not uploaded. Figures were not inserted into readme. Dependency and reference are not written. The report is a bit informal and hard to find the important information.
  2. Implementation: Well-implemented functions and classes. Used ArgParse to set hyerparameters.
  3. Design: Great
  4. Comment: Sufficient
  5. Difficulty: Easy

@hanemma7moud hanemma7moud added the PDF PDF submitted label Nov 13, 2024
@gayanku
Copy link
Collaborator

gayanku commented Nov 14, 2024

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
No Header blocks. -1
Recognition Problem
Good solution to problem.
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting present.
No Data leakage found.
Difficulty : Easy. UNet2D (Easy Difficulty)-10
Commit Log
Good Meaningful commit messages.
Good Progressive commits.
Documentation
Readme :Acceptable. Missing plots/figures. Report tone incorrect. -4
Model/technical explanation :Acceptable. -2
Description and Comments :Good. No references.
Markdown used and PDF submitted. PDF checked.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch). Submitted on time.
No Feedback required.
Request Description is adequate. -1
TOTAL-18

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

@gayanku gayanku added help wanted Extra attention is needed Preliminary Grade To be confirmed after review. labels Nov 14, 2024
@hanemma7moud
Copy link
Collaborator

Robert Slomka

@shakes76
Copy link
Owner

Likely data leakage with such high validation score -1

@shakes76 shakes76 added Completed Updated_Grade BB grade needs adjustment and removed help wanted Extra attention is needed labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB Completed PDF PDF submitted Preliminary Grade To be confirmed after review. _UNet2D Updated_Grade BB grade needs adjustment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants