Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D-UNet Image Segmentation of HipMRI slices #157

Open
wants to merge 18 commits into
base: topic-recognition
Choose a base branch
from

Conversation

LiftedFordRanger
Copy link

This repository contains a model which attempts to segment 2D slices of HipMRI data using a UNet.
It contains the following files:
dataset.py - Contains subroutines used for loading and preprocessing data in the nifti format
modules.py - Contains the structure for the UNet model
train.py - The main training script for training the model
predict.py - Used for model inference by loading a set a model weights
graphs - folder containing predicted and true segmentation masks, dice loss during training and images used in the README

Student Number- 46991638

@yexincheng
Copy link
Collaborator

This is an initial inspection, no action is required at this point

  1. Solves problem: The problem is appropriately solved, the average DICE score reached around 075. DICE score and prediction figures of validation set are reported.
  2. Implementation: Hpyerparameters were hard-coded. Training metric and prediction metric should be DICE rather than DICE loss (1- DICE). Othwise all good.
  3. Design: Good.
  4. Comment: Basic comments, some functions do not have comments. More detailed docstring would be better. A wrong comment, it is ploting DICE score not loss.
  5. Difficulty: Easy

@hanemma7moud hanemma7moud added the PDF PDF submitted label Nov 13, 2024
@gayanku
Copy link
Collaborator

gayanku commented Nov 14, 2024

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
Header blocks.
Recognition Problem
OK solution to problem. -1
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting missing. -1
No Data leakage found.
Difficulty : Easy. UNet2D (Easy Difficulty)-10
Commit Log
Good Meaningful commit messages.
Some/Adequate Progressive commits. -1
Documentation
Readme :Good.
Model/technical explanation :Good.
Description and Comments :Good.
Markdown used and PDF submitted. PDF checked.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch). Submitted on time.
No Feedback required.
Request Description is good.
TOTAL-13

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

@gayanku gayanku added the Preliminary Grade To be confirmed after review. label Nov 14, 2024
@hanemma7moud
Copy link
Collaborator

Daniel Cottrell

@LiftedFordRanger
Copy link
Author

Hey team I just noticed I only put my student number not my name I'm not sure who Daniel Cottrell is but I'm Jayke Braga. My student number above is correct 46991638. My grades aren't showing up on blackboard either.

@shakes76 shakes76 added Completed Updated_Grade BB grade needs adjustment labels Nov 19, 2024
@shakes76
Copy link
Owner

Cant merge because of conflicting changes to main repo files. Please update for merge, doesn't affect grade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB Completed PDF PDF submitted Preliminary Grade To be confirmed after review. _UNet2D Updated_Grade BB grade needs adjustment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants