Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OASIS brain data set using VQVAE - Daniel Miller 45810536 #458

Open
wants to merge 30 commits into
base: topic-recognition
Choose a base branch
from

Conversation

dapmiller
Copy link

A VQVAE in tensorflow has been implemented to generate reconstructed images from OASIS brain dataset. When reconstructing images from VQVAE, a SSIM of 0.734 was achieved. A readme file explains the process and gives a brief rundown of how it works.

Files included:
modules.py: VQVAE model
dataset.py: data loader
train.py: training functions
predict.py: predicts results using model
readme_images: summary

Daniel Miller and others added 30 commits October 11, 2022 16:16
…ataset and the other loads the training images into a numpy array
….py file for normalising and preprocessing training data
…th one hot encoding. Train.py now calls this for training data.
…owever, quantised layer function still needs to be implemented and is currently preventing the code to run.
…tion from dataset.py. Reformatted the functions in modules.py -> encoder and decoder are now in terms of modules instead of sequenitial and the vq layer and overall model builder are in classes to allow other atrributes to be assessed of the model functionality. train.py has reduced in code whereas data is no longer being batched before training (now batched in model.fit). Read.me file has notes being written
… currently does not work however. Training for data is also working, however there is a high loss.
… decrease realistically. The bug occurred due to the value of the variance variable being feed into model.fit.
… calculated incorrectly. Wrote draft read.me file
@SiyuLiu0329
Copy link
Collaborator

This is an initial inspection, no action is required at this point

  • Reconstruction: OK
  • Generative part: pixel-cnn part seems to be missing
  • Readme seems incomplete with placeholder(s)

@shakes76
Copy link
Owner

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate use and implementation (missing pixel CNN) -2
Good spacing and comments
Header blocks

Recognition Problem

Solves problem (no generations) -2
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage (no plots) -1
Module present
Commenting
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages
Progressive commits used

Documentation

ReadMe OK, model info and background missing -2
Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
Feedback required, remove duplicate Readmes -2
Request Description OK, more info would be good -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants