Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s4753993-GCN #477

Open
wants to merge 41 commits into
base: topic-recognition
Choose a base branch
from
Open

Conversation

arshupadhyaya
Copy link

@arshupadhyaya arshupadhyaya commented Oct 23, 2022

Hello Shakes,
This PR, to the best of my knowledge contains files required to run a 2 layer GCN along with TSNE mapping on the facebook.npz dataset. All the work was done on google colab, and I tried my best to create individual modules for the various functions including functions to load data, the model itself as well as training and testing function.
However I was not able to successfully implement a driver function in python, hence I have submitted the jupyter file containing all the functions together.
To successfully run the code please open GCN_final.ipynb, and run all commands in sequential order. Please just ensure file_path to load data matches local environment.
Thank you
Arsh Upadhyaya
(s4753993)

arshupadhyaya and others added 30 commits October 21, 2022 16:34
The previous datatypes for adjacency matrix, and especially features were creating problems during testing phase.
Had trouble returning all four(validation_accuracies,validation_losses,train_accuracies,train_losses) together from one function, so decided to save in np arrays and load the arrays during driver code.
@gayanku gayanku added the GCN label Nov 4, 2022
@gayanku
Copy link
Collaborator

gayanku commented Nov 9, 2022

Looks good. TSNE also fine.

@shakes76
Copy link
Owner

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate use and implementation
Good spacing and comments
Header blocks

Recognition Problem

Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage
Difficulty: Normal -5

Commit Log

Meaningful commit messages, could be more informative -1
Progressive commits used

Documentation

ReadMe acceptable, background/architecture missing -2
Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Wrong Branch) -1
Feedback required, must be pushed to topic-recognition branch not master, please fix -2
Request Description good

@arshupadhyaya arshupadhyaya changed the base branch from master to topic-recognition November 20, 2022 23:20
@arshupadhyaya
Copy link
Author

Hey Shakes, I believe I have fixed the branch issue, also just for knowledge could I know what you mean by README missing background/architecture? Does it mean architecture of the GCN model itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants