Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yeheng_Sun_S4548085_COMP3710_ADNIClassifier #481

Open
wants to merge 19 commits into
base: topic-recognition
Choose a base branch
from

Conversation

SteveSun1015
Copy link

@SteveSun1015 SteveSun1015 commented Oct 25, 2022

The code is written to provide a solution for problem 6 which is Classify Alzheimer’s disease (normal and AD) of the ADNI brain dataset using a visual transformer.

Commit log explanation:
The "Prepare Data" download the Alzheimer’s disease images from "https://cloudstor.aarnet.edu.au/plus/s/L6bbssKhUoUdTSI/download".

The "finished dataset.py" loads all the images by opencv

The "init need py file, draft module.py" constructs the structure of the root directory with the need. py file. Also codes the structure of the model.

The "draft train.py and start training" finished the train.py script and started training the model.

The "Use dataloader to load data" change the code in dataset.py as used opencv to load all the images before training need a lot of ram which makes the training cannot have a good image size and batch size. So I use a tensorflow image loader to load the images instead of an opencv.

The "Final Draft" saves the model. h5 (weights of the model), draft the predict.py and readme

The "Finish predict.py and visualisation" and "finish Read me" finished the predict.py which load the weight and evaluate the model and finished the readme.md

The "Delete image dataset from git" deletes all the images for training and testing.

---------------------------------------------------------------------------------------------------------------4

FINAL CHECK
As I run the script in a cloud server, I found that there are some mistakes in hyperparameters and modules compared to the script in cloud. So some new commits change the hyperparameters and module

@SteveSun1015 SteveSun1015 changed the title StevenSun COMP3710 ADNIClassifier Yeheng_Sun_S4548085_COMP3710_ADNIClassifier Oct 26, 2022
@LinfengLiu98
Copy link
Collaborator

This is an initial inspection, no action is required at this point

ViT design: Great
Preprocessing: Only did train, validation split. Need a test set after training
Model training: Great
Commit log: Great

@SteveSun1015
Copy link
Author

This is an initial inspection, no action is required at this point

ViT design: Great Preprocessing: Only did train, validation split. Need a test set after training Model training: Great Commit log: Great

Hi Linfeng, I think I probably do have the test set by the code "test_ds = dataset.createTestData()" at the predict.py file, could you please double check it for me? Thanks

@LinfengLiu98
Copy link
Collaborator

This is an initial inspection, no action is required at this point
ViT design: Great Preprocessing: Only did train, validation split. Need a test set after training Model training: Great Commit log: Great

Hi Linfeng, I think I probably do have the test set by the code "test_ds = dataset.createTestData()" at the predict.py file, could you please double check it for me? Thanks

Do you have a validation set? So when you do the data split, you need to create train, validation and test set. If you have, please clarify in the README: e.g.: Training set: xxxxx number of images, Validation set: xxxxx number of images, Test set: xxxxx number of images. From what I can see you have a training and a val/test set. If you use the test set during training that's actually the validation set then you are missing a test set no matter how you call it. If you use the test set after training then you are missing a validation set.

@SteveSun1015
Copy link
Author

SteveSun1015 commented Nov 15, 2022 via email

@shakes76
Copy link
Owner

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate use and implementation
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem (no testing results) -2
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage (no test set) -1
Difficulty: Hard

Commit Log

Meaningful commit messages, could be more informative -1
Progressive commits used

Documentation

ReadMe acceptable, no architecture -1
Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
Feedback required, remove model weights -2
Request Description good
Late -12 (restored if extension was approved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants