Added ROI Based Daily Combo and Best Card Only Upgrade Modes #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Settings added: - BEST_COMBO_ONLY - BEST_CARD_ONLY - MAX_PRICE_LIMIT - Now, you can set the "BEST_COMBO_ONLY" seting to "True" for the bot to check the the ratio (ROI) of all three daily combo cards minus the 5 million coin bonus to see if the the ROI is within the Top 5 best cards before it upgrades the daily combo cards. - The "BEST_CARD_ONLY" setting, when set to "True", makes the bot wait for and upgrade on the current BEST card. If that card is on cooldown and this setting is set to "True", then the bot waits for the cooldown to end, and then upgrades the card. - The max_price_limit variable, as I understand it, sets the maximum possible amount of money to spend within a day regards of the "MAX_PRICE" setting. I added a boolean "MAX_PRICE_LIMIT" setting to turn this off, if the user wants to. Other changes: - Removed 0.8 multiplication factor to free_money. Why is it there when the "BALANCE_TO_SAVE" setting exists? I don't understand. - Fixed (shamhi#2350) - Pushed all the sleep statements under their respective if blocks. This gets annoying if you are only interested in, say, Auto Upgrades. The bot would just sleep for like 10 - 20 seconds after logging in before it starts upgrading cards.
… < price - This bug occured when the user didn't have enough money for the purchase, and the BEST_CARD_ONLY setting is set. - The bot would just infintely sleep for 0 seconds and login again until the balance was enough to purchase the best card. - To fix this issue I removed the check for "free_money <= price" when building the queue, and instead, added the check before the upgrade was performed. Also, I removed the "sleep for best card" statements I added at the end of the execution of all tasks. Other Bug fixes: - The bot didn't update the "balance" variable by 1,000,000 coins when it claimed daily ciphers. QoL Change: - Sleep for the exact amount of time required to earn the money when upgrading with BEST_CARD_ONLY,and the currently available moeny isn't enough.
- Track "balance" updates after sleeping for the required amount of time to earn the money used to upgrade the best card.
- Also fixed minor issue with regular daily combo upgrades
- Additionally Fixed a case where bot wasn't upgrading best card due to no upgrade statement after waiting
- Additionally added a way to keep track of balance changes every upgrade. If the user chose a high UPGRADES_COUNT setting, the balance would've started to gradually get out of sync.
|
Any Mergers? |
|
This is really very nice and functional, merge to main asap please :) |
- Additionally fixed minor issue with old/inefficient method that was trying to upgrade cards on cd
|
If anyone would like to use these features you can use them in my fork until the owner decides to merge them. Note: They are not on the main branch they are on the roi_based_daily_combo branch, so you will have to do git checkout roi_based_daily_comboAfter you clone the repo. |
Good work) |
kaeeraa
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings added:
Now, you can set the "BEST_COMBO_ONLY" setting to "True" for the bot to check the ratio (ROI) of all three daily combo cards minus the 5 million coin bonus to see if the ROI is within the Top 5 best cards before it upgrades the daily combo cards.
The "BEST_CARD_ONLY" setting, when set to "True", makes the bot wait for and upgrade only the current BEST card. If that card is on cooldown and this setting is set to "True", then the bot waits for the cooldown to end, and then upgrades the card.
The max_price_limit variable, as I understand it, sets the maximum possible amount of money to spend within a day regardless of the "MAX_PRICE" setting. I added a boolean "MAX_PRICE_LIMIT" setting to turn this on or off, if the user wants to.
Other changes: