Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dry out describe path functions #420

Closed
wants to merge 4 commits into from
Closed

dry out describe path functions #420

wants to merge 4 commits into from

Conversation

mrnerdhair
Copy link
Contributor

@mrnerdhair mrnerdhair commented Feb 12, 2022 •
edited
Loading

This moves all path description functions into core and removes all the not-quite-identical duplicates in individual wallet packages.

Edit: now rebased on #485.

@vercel
Copy link

vercel bot commented Feb 12, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shapeshift/hdwallet/Fq6Jw1jvqQBb8dotJgPmLyJRkbSi
✅ Preview: https://hdwallet-git-dry-out-paths-shapeshift.vercel.app

@mrnerdhair mrnerdhair mentioned this pull request Feb 12, 2022
Closed
@mrnerdhair mrnerdhair mentioned this pull request Feb 12, 2022
Closed
@mrnerdhair mrnerdhair added backwards-compatible reopen-later Stuff that's good to go but not a priority at the moment. labels Mar 4, 2022
@mrnerdhair mrnerdhair closed this Mar 5, 2022
@mrnerdhair mrnerdhair added this to the Low Priority milestone Mar 5, 2022
@mrnerdhair mrnerdhair mentioned this pull request Mar 14, 2022
Open
@mrnerdhair mrnerdhair linked an issue Mar 17, 2022 that may be closed by this pull request
Path description logic is duplicated across wallets #457
Open
@mrnerdhair mrnerdhair reopened this Apr 7, 2022
@mrnerdhair mrnerdhair marked this pull request as draft April 7, 2022 21:33
@mrnerdhair mrnerdhair removed the reopen-later Stuff that's good to go but not a priority at the moment. label Apr 7, 2022
@mrnerdhair mrnerdhair marked this pull request as ready for review April 7, 2022 22:14
@mrnerdhair mrnerdhair requested a review from cjthompson April 12, 2022 23:31
@mrnerdhair mrnerdhair removed this from the Low Priority milestone Apr 12, 2022
@0xean
Copy link
Contributor

0xean commented Jan 29, 2024

Closing as this has become overly stale at this point.

@0xean 0xean closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastaghost pastaghost Awaiting requested review from pastaghost

@0xdef1cafe 0xdef1cafe Awaiting requested review from 0xdef1cafe

@cjthompson cjthompson Awaiting requested review from cjthompson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path description logic is duplicated across wallets
2 participants
@mrnerdhair @0xean