Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turn off eip1559 support for keepkey #665

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

kaladinlight
Copy link
Contributor

There are a handful of edge cases revolving around successfully broadcasting EIP1559 transactions via KeepKey. Until these issues can be resolved, turn of EIP1559 support for KeepKey.

Additional context:

@kaladinlight kaladinlight requested a review from a team as a code owner February 19, 2024 21:34
Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 9:44pm

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested at runtime but changeset looks sane

@kaladinlight kaladinlight merged commit 3c79c89 into master Feb 19, 2024
6 checks passed
@kaladinlight kaladinlight deleted the kk-disable-eip1559 branch February 19, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants