Feat/on chain accounting #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xean
force-pushed
the
feat/on-chain-accounting
branch
from
3666a2e to
82e7693
Compare
There was a problem hiding this comment.
First pass - looks good to me and actually brings a lot less additional logic in than expected.
A bunch of nitpicks to disregard, but conceptually this sounds very sane.
The only thing that may not be a nitpick is we may want to leverage emitting events more, but at the end of the day we'd still need to go through historical blocks so this may be fluff?
I think we now have two ways to do off-chain accounting.
Combining both of these allows us to double check our work and flexibility for different scenarios. |
gomesalexandre
approved these changes
May 15, 2024
woodenfurniture
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add on-chain accounting for "rewards" a generic unit of account that we can use to reconcile off chain for RUNE distribution. Essentially, they act like points.
Also adds some paranoia with a non-reentrant modifier...
Only last question is should we add the ability to set the REWARD_RATE so that if we end up using these as points, and we have multiple pools as is being discussed with DFC, we can modify the REWARD_RATE to be meaningful.