feat: refactor for staking token to be generic #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
approved these changes
May 16, 2024
There was a problem hiding this comment.
LGTM - does what it says on the box as far as generalizing the staking token, a few references remaining in comments and require strings we probably want to tackle too, and other, less relevant references we may want to tackle as well in tests and deployment scripts
|
@gomesalexandre made another deeper pass, please check again. Included scripts, etc. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes "FOX" so the token that is being staked is generic in case we use it for LP tokens as well.
Absolutely no functional changes should have been introduced here.
closes #42