Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use anvil for local rewards distribution script contract deployments #49

Merged
merged 1 commit into from
May 30, 2024

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented May 27, 2024

Relates to #10

Brings the original rewards distribution script back into a working state with our upgradeable proxy.

Performs contract deployment to local fork via anvil which also uses our production-ready contract deploy script to ensure the proxy is correctly deployed with initialization.

Adds some extra debugging, safer/corrected log parsing and type safety improvements.

Doesn't actually change or improve the original staking rewards script flow and logic - this will be done in follow-up task.

@woodenfurniture woodenfurniture changed the title fix: use anvil for local rewards distribution script fix: use anvil for local rewards distribution script contract deployments May 27, 2024
@gomesalexandre gomesalexandre self-requested a review May 27, 2024 08:59
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM! One comment re: updating README with instructions about the new script but otherwise happy to get this in

@woodenfurniture woodenfurniture merged commit 83b361d into main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants