fix: better narrowing

shapeshift · May 6, 2024 · 5b8e3ed · 5b8e3ed
1 parent dfe5711
commit 5b8e3ed
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/pages/ThorChainLP/utils.ts b/src/pages/ThorChainLP/utils.ts
@@ -11,7 +11,7 @@ export type Opportunity = {
 export const fromOpportunityId = (opportunityId: string): Opportunity => {
   const [assetId, type] = opportunityId.split('*')
 
-  if (!assetId) throw new Error(`Invalid opportunityId: ${opportunityId}`)
+  if (!assetId || !type) throw new Error(`Invalid opportunityId: ${opportunityId}`)
 
   fromAssetId(assetId)