Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to send BTC to taproot addresses #6761

Open
purelycrickets opened this issue Apr 25, 2024 · 3 comments
Open

Unable to send BTC to taproot addresses #6761

purelycrickets opened this issue Apr 25, 2024 · 3 comments
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@purelycrickets
Copy link

purelycrickets commented Apr 25, 2024

Overview

Currently being reported by users in both MetaMask and Mobile and able to be recreated by Ops with native. In production, users are unable to send to BTC taproot addresses, however the app allows users to go through the transaction building flow resulting in an error and not a successful transaction

References and additional details

Screen.Recording.2024-04-25.at.1.11.17.PM.mov

Screen recording of the error in action^

Recreation steps:

  1. Find taproot style BTC address to test a send to (I used Coolwallet)
  2. Attempt a BTC send to that taproot address for any amount of funds.
  3. Witness the errors in the console log when the address is entered.
  4. Continue to attempt to broadcast the transaction and witness the 'User rejected the transaction' error.
Error from logs unstoppable-domains.ts:79 Error: invalid address (argument="address", value="bc1pxk2u9kjszfzxqmsrcctvst32dn2pqrlptsw0e7wqumhlq9cl35ks9v5kh2", code=INVALID_ARGUMENT, version=address/5.7.0) (argument="addr", value="bc1pxk2u9kjszfzxqmsrcctvst32dn2pqrlptsw0e7wqumhlq9cl35ks9v5kh2", code=INVALID_ARGUMENT, version=abi/5.7.0) at u.makeError (index.ts:224:23) at u.throwError (index.ts:233:20) at u.throwArgumentError (index.ts:236:21) at i._throwError (abstract-coder.ts:38:16) at i.encode (address.ts:17:18) at array.ts:57:19 at Array.forEach () at u (array.ts:43:12) at k.encode (tuple.ts:51:16) at R.encode (abi-coder.ts:86:15) f @ unstoppable-domains.ts:79 await in f (async) k @ address.ts:239 I @ address.ts:324 await in I (async) validateAddress @ Address.tsx:73 Re @ isCheckBoxInput.ts:1306 U @ isCheckBoxInput.ts:1558 T @ isCheckBoxInput.ts:1399 R @ isCheckBoxInput.ts:1458 Te @ isCheckBoxInput.ts:1872 B @ isCheckBoxInput.ts:364 H @ isCheckBoxInput.ts:479 _o @ react-dom.production.min.js:167 El @ react-dom.production.min.js:290 bs @ react-dom.production.min.js:280 ms @ react-dom.production.min.js:280 ys @ react-dom.production.min.js:280 is @ react-dom.production.min.js:268 k @ scheduler.production.min.js:13 P @ scheduler.production.min.js:14 Show 15 more frames Show less useFormSend.tsx:58 Error: failed to add output: Error: bc1pxk2u9kjszfzxqmsrcctvst32dn2pqrlptsw0e7wqumhlq9cl35ks9v5kh2 has no matching Script at B. (bitcoin.ts:312:39) at Generator.next () at bitcoin.ts:31:71 at new Promise () at a (bitcoin.ts:27:12) at bitcoin.ts:287:67 at Array.map () at B. (bitcoin.ts:287:51) at Generator.next () at s (bitcoin.ts:28:58)

Acceptance Criteria

  • Users are able to send to taproot BTC addresses
  • Not full taproot support (wallet support / address generation)

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@purelycrickets purelycrickets added bug Something isn't working needs engineering Requires engineering input before bounty labels Apr 25, 2024
@purelycrickets
Copy link
Author

From @gomesalexandre in discord: "Yeah pretty sure we don't support sending to P2TR, should be super easy to detect and we could add some error messaging and disabled state early on!"

@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Apr 29, 2024
@0xean
Copy link
Contributor

0xean commented Jul 15, 2024

holding on a fix since we are contemplating taproot at the product level for the moment.

@0xean 0xean added the blocked label Jul 15, 2024
@0xean 0xean moved this from Up next / groomed to Blocked in ShapeShift Dashboard Jul 22, 2024
@0xApotheosis 0xApotheosis changed the title Unable to BTC to taproot addresses Unable to send BTC to taproot addresses Sep 23, 2024
@gomesalexandre gomesalexandre moved this from Blocked to Backlog in ShapeShift Dashboard Nov 4, 2024
@twblack88
Copy link
Contributor

It's time. For chainflip and to be more modern.

@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
Status: Up next / groomed
Development

No branches or pull requests

4 participants