Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arb bridge implementation for rFOX #6978

Closed
0xean opened this issue May 23, 2024 · 7 comments
Closed

Arb bridge implementation for rFOX #6978

0xean opened this issue May 23, 2024 · 7 comments
Labels
needs grooming needs product Requires product input before bounty

Comments

@0xean
Copy link
Contributor

0xean commented May 23, 2024

The arbitrum bridge is the primary way we expect users and dao contributors to move FOX between mainnet and arb. It would be nice to have this intergrated into our UI both as a "swapper" and integrated into the rFOX staking flow as show in the figma

This ticket is specifically for the rFOX implementation, but we should as much of the bridge tx logic reusable for integration into the swapper as well

Docs:

https://docs.arbitrum.io/build-decentralized-apps/token-bridging/overview
https://github.com/OffchainLabs/arbitrum-tutorials/tree/master/packages/token-deposit

@shapeshift/product will add copy for an additional warning that is displayed in the flow that alerts the user that bridging back will take 7 days and can be done using the arbitrum bridge.

@0xean
Copy link
Contributor Author

0xean commented May 23, 2024

#6968 (comment)

@0xean
Copy link
Contributor Author

0xean commented May 23, 2024

@shapeshift/product - we may want some additional messaging warning users to the delay in bridging back from L2 -> ETH. 7 days

https://docs.arbitrum.io/arbitrum-bridge/quickstart#withdraw-eth-or-erc-20-tokens-from-child-chain-to-parent-chain

cc @twblack88 / @reallybeard

@gomesalexandre
Copy link
Contributor

@twblack88 / @reallybeard in addition to a warning ack of sorts, we'll also want to change the copy and UI at confirm step:

image
  • "Successfully received FOX on Ethereum" -> I didn't, since there's 7 days to withdraw
  • 1 FOX -> probably needs a little UI reminder that this isn't there yet and they will need to claim it in 7 days
  • re: claim Tx, not sure we'll want to implement claim functionality or even claim available notification in the app (i.e we'd have to alway poll on app load, and even if we do, where would it fit in the app visually? we don't really have a list of actionable "notifications" of sorts yet) but should probably find a nice place to link them to Arbitrum Bridge UI after "swapping" so they can eventually claim there

@gomesalexandre gomesalexandre added the needs product Requires product input before bounty label May 24, 2024
@twblack88
Copy link
Contributor

Great callouts @gomesalexandre . i think there are two options:

  • change up copy and add a warning (either modal or inline). add a link to the native bridge
  • build a unified Bridge claims route (allowing us to do more bridges down the line )

@gomesalexandre
Copy link
Contributor

Definitely inclined towards option 1 @twblack88, the second option is a much bigger lift and won't really fit swapper pattern. We don't just need a route, we need to be able to poll somehow, somewhere in the app and notify users somewhere, that they have a claim ready.

Happy to discuss the notification feature we previously brought the idea of, but that's an absolute stretch here

@0xean
Copy link
Contributor Author

0xean commented May 28, 2024

#7009
#7010

implementation tickets for this specifically into rFOX

@NeOMakinG
Copy link
Collaborator

Seems like it's done!

@github-project-automation github-project-automation bot moved this from Backlog to Done in ShapeShift Dashboard Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs grooming needs product Requires product input before bounty
Projects
Status: Done
Development

No branches or pull requests

4 participants