Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit into BTC saver has Continue button greyed out when should say "Minimum amount XYZ" or "Insufficient Funds" #7105

Closed
2 tasks done
MBMaria opened this issue Jun 12, 2024 · 2 comments · Fixed by #7136
Assignees
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Jun 12, 2024

Overview

When trying to deposit into BTC saver vault , currently it doesnt matter what value you select it will have the continue button greyed out if it is not enough to proceed with the deposit - does not tell you it needs a minimum amount or that you have insufficient funds

References and additional details

https://jam.dev/c/efc95387-aad6-4c36-9ee1-6405b301a1a1
image

Acceptance Criteria

Modal should give correct error messaging

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Jun 12, 2024
@gomesalexandre gomesalexandre self-assigned this Jun 12, 2024
@gomesalexandre
Copy link
Contributor

@MBMaria looks like this may have been caused by intermittent BTC node issues? Currently able to get a minimum, as well as a valid quote (though not enough funds to confirm this works to preview)

image

@MBMaria
Copy link
Author

MBMaria commented Jun 12, 2024

If i type in an amount to deposit the errors will show, but if i select and of the percent amounts it will just have continue greyed out
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants