Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deposit rugged validation on percent option click #7136

Merged
merged 3 commits into from
Jun 14, 2024
Merged

fix: deposit rugged validation on percent option click #7136

merged 3 commits into from
Jun 14, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jun 14, 2024 •
edited
Loading

Description

Fixes validation being triggered, but not surfaced on percent option click for deposits (spotted with THORChain savers deposits)

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #7105

Risk

High Risk PRs Require 2 approvals

Low - ensure validation still works on input, and now properly works on percent option change for THORChain savers deposits.

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

  • THORChain savers deposits validation is now happy on percent option click
  • THORChain savers deposits validation is still happy on input

Engineering

  • ^

Operations

  • ^

Screenshots (if applicable)

https://jam.dev/c/234119a4-be46-4ed6-9f7f-6a1ba96c0ade

@gomesalexandre gomesalexandre requested a review from a team as a code owner June 14, 2024 10:07
@gomesalexandre gomesalexandre marked this pull request as draft June 14, 2024 10:07
@gomesalexandre gomesalexandre marked this pull request as ready for review June 14, 2024 10:14
NeOMakinG
NeOMakinG approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual overflow validation

image

Manual in-between validation

image

Percent 50% error expected validation

image

Percent max validation success expected

image

LGTM ✅

@gomesalexandre gomesalexandre enabled auto-merge (squash) June 14, 2024 13:48
@gomesalexandre gomesalexandre merged commit 09f6d25 into develop Jun 14, 2024
6 checks passed
@gomesalexandre gomesalexandre deleted the fix_percent_validation branch June 14, 2024 13:54
@woodenfurniture woodenfurniture mentioned this pull request Jun 16, 2024
Merged
woodenfurniture added a commit that referenced this pull request Jun 17, 2024
@woodenfurniture
fix: revert deposit rugged validation on percent option click (#7136)
21a6a58 
This reverts commit 09f6d25.
@gomesalexandre gomesalexandre restored the fix_percent_validation branch June 17, 2024 07:50
@gomesalexandre gomesalexandre mentioned this pull request Jun 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gomesalexandre @NeOMakinG