-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wire-up Ledger hdwallet #5336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
gomesalexandre
commented
Sep 21, 2023
gomesalexandre
commented
Sep 21, 2023
3 tasks
woodenfurniture
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conceptually LGTM, pushing this to wood for ops to test before merging (as i don't have a ledger)
12 tasks
Merging as this has ops signoff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working in this base functionality PR:
'TransportRaceCondition: An action was already pending on the Ledger device. Please deny or reconnect.'
conditionDisconnectedDeviceDuringOperation: Failed to execute 'transferOut' on 'USBDevice': The device was disconnected.
To be implemented in follow-ups:
call()
to specific apps?Pull Request Type
Issue (if applicable)
N/A
Risk
Large regression risk in
useReceiveAddress
/getReceiveAddress
being too strongly memoized i.e stale receive address on wallet change/"update" for all wallets. Think things like next receive address being broken for UTXOs, receive addresses when switching wallets or MM account being the one from the previously connected wallet/account, etc.Testing
Engineering
Operations
Screenshots (if applicable)
connect.mov
Note the non-standard receive address for BCH here - to be tackled in a follow-up. It does work (tested with self sends as can be seen above), although does shows up with a warning WRT unverfied inputs on the Ledger currently, which may be related to the address format.