fix: bch Ledger address verify

[gomesalexandre]

Description

Passes the correct scriptType for BitcoinCash in getAddress down the line, instead of having Ledger give us a Legacy address then converting it into a CashAddr. This works in most cases UX-wise, but won't cut it when actually verifying addresses on the device, since Legacy will be used, and users would be confused as to why verification passed despite address being different (or simply refuse continuing since, well those are different).

Pull Request Type

• 🐛 Bug fix (Non-breaking Change: Fixes an issue)
• 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
• 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #

Risk

None - now in Ledger-land only (bec83f9) since this was causing native regressions

Moderate - specifying a cashaddr scriptType should be a no-op, but receive address for all BCH-supporting wallets should be tested

Testing

• Verify your BCH address in Ledger

• Ensure the address you see is the same as the one on the device

• Ensure BCH addresses as well as address verification is showing no regression in native

Engineering

• ☝🏽

Operations

• ☝🏽

Screenshots (if applicable)

• Native

• Ledger

[gomesalexandre]

Current dependencies on/for this PR:

• develop
  • PR feat: remove getReceiveAddress caching #5497
    • PR fix: bch Ledger address verify #5499 👈

This comment was auto-generated by Graphite.

[gomesalexandre]

Closing in favor of shapeshift/hdwallet#650