fix: parse buy txid from midgard actions #6813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous double swap logic was incorrect resulting in rune swaps polling the wrong txid against the wrong chain. This logic removes the double swap condition and instead just attempts to get the latest txid specified in the outbound transactions array. This will evaluate in three different ways:
sellTxId
and rely on the swap status for confirmation (sellTxId
doesn't appear to actually be used in the downstream logic due to thehasOutboundTx
variable in swapperendpoints.ts
)sellTxId
on the first rune swap outbound and rely on swap status which will be pending, and then wait for the final outbound asset tx and return the txid for the buy chain to poll status forPull Request Type
Issue (if applicable)
N/A
Risk
Medium - this changes transaction confirmation logic
Thorchain Swaps
Testing
Engineering
☝️
Operations
☝️
Screenshots (if applicable)