Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable scroll when menu drawer is opened #6955

Merged

Conversation

NeOMakinG
Copy link
Collaborator

@NeOMakinG NeOMakinG commented May 21, 2024

Description

Opening modals while the menu drawer is opened on mobile cause scrolling issues inside modals

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

Not so risky but you can scroll the content while the menu drawer is opened now, we might wan't to grain fine this fix but for now it fixes some issues with modals

Testing

See shapeshift/mobile-app#96 (comment)

Prerequisites

  • Enable responsive (on a small enough device e.g iPhone SE a.k.a 375 * 667)
image
  • Note, the default behavior of devtools while in responsive is it disables your desktop's native scroll and you have to swipe, similar to mobile instead. If that's weird for you and you want to scroll the usual way, you can always change the behavior by
    • clicking "Add Device" here. This will add a new option to your devtools responsive view, to choose the device type. Then choose "Desktop"
    • then select responsive as a device, and input the same resolution as iPhone SE (i.e 375 * 667) manually
image

Actual testing

  • Ensure you can still scroll the side drawer
  • Ensure WC dApps modal is now scrollable

Engineering

Operations

Screenshots (if applicable)

image

@NeOMakinG NeOMakinG requested a review from a team as a code owner May 21, 2024 11:19
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute animal @NeOMakinG - confirmed this fixed the issue with scrolling

https://jam.dev/c/41fd1c60-838c-4590-844a-f48161ea5866

Also sanity tested the backup passphrase modal and confirmed it's still happy

@gomesalexandre gomesalexandre enabled auto-merge (squash) May 21, 2024 11:44
@gomesalexandre gomesalexandre merged commit c6d43f8 into shapeshift:develop May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants