Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add FOX on arb as a related FOX asset #7096

Merged
merged 4 commits into from
Jun 13, 2024
Merged

feat: add FOX on arb as a related FOX asset #7096

merged 4 commits into from
Jun 13, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jun 11, 2024 •
edited
Loading

Description

Does what it says on the box. This PR:

  • Adds FOX on Arb as a manual related asset
  • Merges manual and Zerion related assets in script (filtering out dupes) vs. having manual or zerion previously
  • Regenerates asset data

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #7075

Risk

High Risk PRs Require 2 approvals

Low to none

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

  • FOX on Arbitrum is available as a related FOX asset across the app, including in RFOx staking
  • Do a quick smoke test on other related assets and ensure there's no regressions there

Engineering

  • ^

Operations

  • ^

Screenshots (if applicable)

  • Related assets dropdown is available in RFOX staking
Screenshot 2024-06-11 at 14 50 58
  • Related assets are happy. This diff (left) vs. develop (right):
Screenshot 2024-06-11 at 14 50 34 Screenshot 2024-06-11 at 14 50 12 Screenshot 2024-06-11 at 14 49 54 Screenshot 2024-06-11 at 14 49 35

@gomesalexandre gomesalexandre requested a review from a team as a code owner June 11, 2024 12:53
@woodenfurniture woodenfurniture merged commit 54ea72f into develop Jun 13, 2024
1 check passed
@woodenfurniture woodenfurniture deleted the feat_fox_arb_related_asset branch June 13, 2024 00:37
@woodenfurniture woodenfurniture mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodenfurniture woodenfurniture woodenfurniture approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FOX on Arb as a related AssetId
2 participants
@gomesalexandre @woodenfurniture