Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rFOX arbitrum Txs parser #7137

Merged
merged 7 commits into from
Jun 14, 2024
Merged

feat: rFOX arbitrum Txs parser #7137

merged 7 commits into from
Jun 14, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jun 14, 2024

Description

Adds unchained-client parsing for rFOX Txs on Arbitrum.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #7120

Risk

High Risk PRs Require 2 approvals

Low - ensure the right guards are in place in unchained-client parsing so this early bails on Txs other than rFOX ones.

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

  • rFOX Txs are parsed (see screenshot)

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

image

@gomesalexandre gomesalexandre changed the title [skip ci] wip: efox arbitrum Txs parser feat: rFOX arbitrum Txs parser Jun 14, 2024
@gomesalexandre gomesalexandre marked this pull request as ready for review June 14, 2024 13:45
@gomesalexandre gomesalexandre requested a review from a team as a code owner June 14, 2024 13:45
@kaladinlight
Copy link
Contributor

I added a couple of updates:

  • Test mocks use exact return data from unchained api
  • Update tests to use the from address to show correct fees and transfers
  • Add extra metadata for runeAddress and claimIndex (claimIndex unused currently)
  • Add rune address to transaction row
  • Add unstake amount to transaction row
  • Update unstake to unstakeRequest so it doesn't show as a receive transaction
  • Extend TransactionDetails/Amount.tsx to support assetId (let me know if you know a better component for crypto amount with assetId to control symbol and precision)

image
image
image
image

@gomesalexandre
Copy link
Contributor Author

I added a couple of updates:

@kaladinlight can't stamp my own PR but looks perf, get in!

@gomesalexandre gomesalexandre enabled auto-merge (squash) June 14, 2024 19:01
@gomesalexandre gomesalexandre merged commit e9634bf into develop Jun 14, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the rfox_evm_parsing branch June 14, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing for rFOX change address transactions
2 participants