Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v1.645.0 #7414

Merged
merged 5 commits into from
Jul 25, 2024
Merged

chore: release v1.645.0 #7414

merged 5 commits into from
Jul 25, 2024

Conversation

gomesalexandre
Copy link
Contributor

feat: implement rfox as an opportunity (#7373)
fix: akschually skip existing related assets (#7408)
fix: global search include assets without market data (#7404)
feat: portals assets generation (#7401)
feat: usdt specific allowance approval flow for swapper (#7237)

woodenfurniture and others added 5 commits July 23, 2024 15:38
* feat: state management and UI to support resetting usdt token allowance to zero

* chore: actually this schema is better

* feat: wire up transaction hooks to allowance reset

* feat: wire up approval reset hooks to redux

* feat: implement usdt approval reset logic in hooks

* fix: disabled should be isDisabled

* feat: hide usdt approval resets behind feature flag

* chore: actioned code review feedback

* chore: use logical chain instead of IIFE switch

Co-authored-by: kevin <[email protected]>

* fix: dont use isFetching to modify approval state

* fix: reset approval requirements before setting them

* fix: implement approval reset state transitions

* track allowance reset tx hash

* cleanup allowance reset and approval states

* improve toggle disable state

---------

Co-authored-by: kevin <[email protected]>
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Sanity checked all page routes

❓ I noticed that when loading the app on fresh cache we initially don't have a receive address (tested with Native wallet). Could this be due to all of the new assets? It stayed this way for about a minute.

Screenshot 2024-07-25 at 4 29 07 PM Screenshot 2024-07-25 at 4 29 31 PM

✅ Sanity checked a trade via the swapper

Screenshot 2024-07-25 at 4 33 44 PM

✅ TX history loading as expected

@0xApotheosis
Copy link
Contributor

0xApotheosis commented Jul 25, 2024

Sanity checked the commit before the Portals work, it was already doing this - I'll make a ticket for better handling of this initial state.

Edit: the ticket: #7419

@0xApotheosis 0xApotheosis merged commit 11bd58a into main Jul 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants