perf: improve tradeQuoteSlice selectors #7560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves:
selectRequiredParamFromFilter
helper that ensures all necessary args are provided to the selectorPull Request Type
Issue (if applicable)
Resolves feedback on a previous PR: #7551 (comment)
Risk
Medium - only type and reactivity changes, though relates to some trade status functionality
Ensure allowance approvals and trade states behave as expected.
Testing
A general sanity check of the swapper and it's trade execution states.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
N/A