Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: halt thorchain operations during hardfork #7679

Closed
wants to merge 3 commits into from

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Sep 3, 2024

Description

⚠️ MERGE ME at 5PM UTC on 09/04 i.e two hours before the hard fork, not before

Does what it says on the box - to be reverted once #7510 goes in

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

None, temporary halt

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • THORChain swapper, LP, Lending, savers and RUNEPool are disabled

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Screenshot 2024-09-03 at 17 43 17 Screenshot 2024-09-03 at 17 42 59 Screenshot 2024-09-03 at 17 41 52 Screenshot 2024-09-03 at 17 33 06

@0xean
Copy link
Contributor

0xean commented Sep 3, 2024

to be merged tomorrow 17 UTC. 2 hours ahead of TC hardfork

@gomesalexandre gomesalexandre marked this pull request as ready for review September 3, 2024 19:46
@gomesalexandre gomesalexandre requested a review from a team as a code owner September 3, 2024 19:46
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity checked yarn env app config:

✅ No THORChain swapper available

Screenshot 2024-09-04 at 6 18 13 AM

✅ Savers deposit and withdraws disabled

Screenshot 2024-09-04 at 6 18 47 AM

❌ Lending & Pools routes are gone. This is not ideal, and too course of a flag - users should still be able to view their positions.

Screenshot 2024-09-04 at 6 23 05 AM

@gomesalexandre
Copy link
Contributor Author

❌ Lending & Pools routes are gone. This is not ideal, and too course of a flag - users should still be able to view their positions.

Nice catch @0xApotheosis! Reverted the top-level flags and only kept the granular ones in a1cb69d

image image

Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 🙏

Positions are accessible, but can't be interacted with. Exactly what we want!

Screenshot 2024-09-04 at 6 53 15 AM

@kaladinlight
Copy link
Contributor

hotfix release: #7690

@kaladinlight kaladinlight deleted the feat_tmp_disable_thor_things branch October 8, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants