Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove express dep #7742

Merged
merged 2 commits into from
Sep 12, 2024
Merged

chore: remove express dep #7742

merged 2 commits into from
Sep 12, 2024

Conversation

0xApotheosis
Copy link
Contributor

Description

Removes express as an explicit import.

Inspired by #7726, noticed we don't actually need this package to be explicitly imported, it's already a peer dependency of webpack-dev-server.

Issue (if applicable)

N/A - maintenance

Risk

Small.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

In theory, none.

Testing

The app should should build and have no regressions.

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

N/A

Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn clean && yarn && yarn build:packages && yarn dev

Seems to work just fine. Quick sanity check of the app works goodly.

@woodenfurniture woodenfurniture enabled auto-merge (squash) September 12, 2024 22:35
@woodenfurniture woodenfurniture merged commit 67591cd into develop Sep 12, 2024
3 checks passed
@woodenfurniture woodenfurniture deleted the remove-express branch September 12, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants