Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: more abi cleanup #7745

Merged
merged 2 commits into from
Sep 13, 2024
Merged

chore: more abi cleanup #7745

merged 2 commits into from
Sep 13, 2024

Conversation

woodenfurniture
Copy link
Member

Description

Removes redundant ABIs, adds as const for added type safety, addresses type safety issues.

Issue (if applicable)

NA

Risk

High Risk PRs Require 2 approvals

Low risk - this is removing unused code and changing type safety only. No logical changes are made.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Sanity check the app runs and high-priority features are not affected.

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

@woodenfurniture woodenfurniture requested a review from a team as a code owner September 13, 2024 03:19
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sane, love me a good clean-up PR.

@0xApotheosis 0xApotheosis enabled auto-merge (squash) September 13, 2024 03:26
@0xApotheosis 0xApotheosis merged commit ccd8589 into develop Sep 13, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the remove-redundant-rfox-abi branch September 13, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants