Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: evergreen fox farming #7749

Merged
merged 5 commits into from
Sep 19, 2024
Merged

feat: evergreen fox farming #7749

merged 5 commits into from
Sep 19, 2024

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Sep 16, 2024

Description

Adds support for the upcoming evergreen staking contract by adding the ABI and type resolution.

A placeholder comment is ready to uncomment when the contact is ready for go-live:

// foxEthStakingAssetIdEvergreen, // TODO: Uncomment when Evergreen staking is ready for go-live

This should have no runtime implications.

Issue (if applicable)

closes #7666

Risk

High Risk PRs Require 2 approvals

Medium as it involves a smart-contract ABI/interaction.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Ensure we do not see an evergreen contract in the DeFi section, or any related requests in the network tab.

For posterity, when the following line is uncommented we see the new evergreen contract:

// foxEthStakingAssetIdEvergreen, // TODO: Uncomment when Evergreen staking is ready for go-live

image

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

See above.

@0xApotheosis
Copy link
Contributor

Contract address updated to the deployed evergreen contract, and confirmed can approve and stake in the deployed contract:

Screenshot 2024-09-18 at 3 18 01 pm Screenshot 2024-09-18 at 3 18 30 pm Screenshot 2024-09-18 at 3 18 47 pm

@0xApotheosis 0xApotheosis marked this pull request as ready for review September 19, 2024 06:53
@0xApotheosis 0xApotheosis requested a review from a team as a code owner September 19, 2024 06:54
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woodenfurniture I'll approve and merge this for velocity.

Since your work I've added the deployed contract and commented the line that causes runtime changes.

@0xApotheosis 0xApotheosis merged commit 9a75b97 into develop Sep 19, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the evergreen-fox-farming branch September 19, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evergreen Fox Farm - Web
2 participants