Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken build post webpack upgrade #7760

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Sep 17, 2024

Description

Force react-scripts to use the same version of workbox-webpack-plugin to ensure we can properly override the maximumFileSizeToCacheInBytes config on the InjectManifest

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

N/A

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

N/A

Screenshots (if applicable)

@kaladinlight kaladinlight requested a review from a team as a code owner September 17, 2024 17:24
@kaladinlight kaladinlight changed the base branch from develop to release September 17, 2024 18:10
@kaladinlight kaladinlight merged commit ed89649 into release Sep 17, 2024
3 checks passed
@kaladinlight kaladinlight deleted the webpack-follow-up branch September 17, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants