Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle thorchain liquidity lockup #7762

Merged
merged 8 commits into from
Sep 19, 2024
Merged

feat: handle thorchain liquidity lockup #7762

merged 8 commits into from
Sep 19, 2024

Conversation

kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Sep 17, 2024 •
edited
Loading

Description

Add info acknowledgement for liquidity lockup period on add liquidity and deposit savers as well as a button error state for liquidity locked on remove liquidity and withdraw savers.

Issue (if applicable)

closes #7708

Risk

High Risk PRs Require 2 approvals

Low

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Ensure you are prompted with an info acknowledgment on add liquidity and deposit savers showing the lockup time before proceeding
  • Ensure you see a button error state on remove liquidity and withdraw savers showing the remaining lockup time if locked, or no error state if unlocked

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

LP:
image
image
image
image

Savers:
image
image

Rune Pool:
image
image

@kaladinlight kaladinlight requested a review from a team as a code owner September 17, 2024 20:12
@kaladinlight kaladinlight marked this pull request as draft September 17, 2024 20:16
@kaladinlight kaladinlight marked this pull request as ready for review September 18, 2024 19:04
0xApotheosis
0xApotheosis reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass code review looking good, onto functional testing.

src/components/Acknowledgement/Acknowledgement.tsx Outdated Show resolved Hide resolved
.../providers/thorchain-savers/components/ThorchainSaversManager/Deposit/components/Deposit.tsx Outdated Show resolved Hide resolved
0xApotheosis
0xApotheosis approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working as described!

LP

Screenshot 2024-09-19 at 11 03 28 am Screenshot 2024-09-19 at 11 07 32 am

Non-locked LP still happy:

Screenshot 2024-09-19 at 11 07 49 am

Savers

Screenshot 2024-09-19 at 11 35 00 am

RUNEPool

Screenshot 2024-09-19 at 11 37 09 am Screenshot 2024-09-19 at 11 56 58 am

gomesalexandre
gomesalexandre reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few smolish comments re: cleanup, but conceptually looks perf 🐐 runtime pass incoming

gomesalexandre
gomesalexandre approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally:

  • Savers

https://jam.dev/c/a8a273d1-887c-4d6e-89c4-bcc09658cc18

  • LP

https://jam.dev/c/5282c8e8-da08-4f9c-99bd-d7a0489430aa

@kaladinlight kaladinlight enabled auto-merge (squash) September 19, 2024 17:53
@kaladinlight kaladinlight merged commit 7f22ed6 into develop Sep 19, 2024
3 checks passed
@kaladinlight kaladinlight deleted the feat-liquidity-lockup branch September 19, 2024 18:00
@0xApotheosis 0xApotheosis mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LP withdraw issues
3 participants
@kaladinlight @gomesalexandre @0xApotheosis