Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: savers consistent withdraw dust amount #7780

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

gomesalexandre
Copy link
Contributor

Description

Fixes a bug spotted while working on #7766

I was unable to broadcast a withdraw Tx, and while debugging things out, noticed that the sum of all my UTXOs was lower than the dust balance value being sent.

The reason behing this is that useSendThorTx() uses default dust amounts, while THORChain savers withdraw confirm step uses upstream dust amount (lower), which meant balance checks weren't working.

Issue (if applicable)

closes N/A

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • Try to withdraw any UTXO (tested with BTC)
  • Ensure THORChain savers withdraw confirm step "Dust Amount" matches the actual on-chain sent value

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

@gomesalexandre gomesalexandre marked this pull request as ready for review September 20, 2024 10:57
@gomesalexandre gomesalexandre requested a review from a team as a code owner September 20, 2024 10:57
@gomesalexandre gomesalexandre enabled auto-merge (squash) September 20, 2024 16:27
@gomesalexandre gomesalexandre merged commit 2b679a1 into develop Sep 20, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_consistent_savers_withdraw_dust branch September 20, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants