feat: disable taproot custom receive addresses in swapper #7781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
commented
Sep 20, 2024
src/assets/translations/en/main.json
Outdated
| @@ -938,6 +938,7 @@ | |||
| "receiveAddress": "Receive Address", | |||
| "receiveAddressDescription": "No %{chainName} address found from connected wallet. Manually enter an address", | |||
| "disableThorNativeSmartContractReceive": "We've detected that you're sending to a smart contract address on %{chainName}. Due to THORChain limitations, receiving %{nativeAssetSymbol} to a smart contract address is not supported. Please enter another address", | |||
| "disableThorTaprootReceive": "We've detected that you're sending to a taproot Bitcoin address. Due to THORChain limitations, receiving BTC to a taproot address is not supported. Please enter another address", | |||
There was a problem hiding this comment.
Not parameterized because dis only for BTC and going away soon so
gomesalexandre
commented
Sep 20, 2024
| variant='ghost' | ||
| onClick={handleEditRecipientAddressClick} | ||
| /> | ||
| <> |
There was a problem hiding this comment.
Disable whitespaces when reviewing this
0xApotheosis
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says on the box
Issue (if applicable)
closes #7779
Risk
Low to none
Testing
Engineering
Operations
Screenshots (if applicable)