-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: markets page coingecko lists and savers recommended assets #7782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very sane so far
I added a few comments mainly about avoiding duplicating constants and questions on thorchain opportunities APY shown as 0
Also noticed a few runtime things:
-
First asset is always using the big size while I think it should only be on the first part of the page
-
After staying for a while on the page, when reloading the page, my tab is crashing
As the last point could be a blocker for our users, blocking this PR until we investigate a bit more
Also noticed an empty page on reload at some points..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing an empty state when not assets returned for a chain
Is there any point to display UTXOs in the chain dropdown, even thorchain?
Looks like some market data are missing or takes a lot of time to load:
Anyway, testing on a fresh env does works like it should, all those feedbacks are not blocking this PR but it would be worth doing them in a followup because the UX would be better!
Description
This PR implements Coingecko categories (Trending, Recently Added, Top Movers, Market Cap, Volume) as well as THORChain savers in recommended page.
Issue (if applicable)
Risk
Testing
Engineering
Operations
Screenshots (if applicable)