Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: markets page coingecko lists and savers recommended assets #7782

Merged
merged 25 commits into from
Sep 25, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Sep 22, 2024

Description

This PR implements Coingecko categories (Trending, Recently Added, Top Movers, Market Cap, Volume) as well as THORChain savers in recommended page.

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Coingecko categories (Trending, Recently Added, Top Movers, Market Cap, Volume) as well as THORChain savers in recommended page look sane. Sanity check data against savers page/Coingecko lists https://www.coingecko.com/en/highlights
  • Narrowing by chain is possible for LP things (portals and savers)
  • Narrowing by chain is not possible for cg categories since they do not allowing chain parameterization in their API

Engineering

  • ☝🏽

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ☝🏽

Screenshots (if applicable)

image image image image

@gomesalexandre gomesalexandre changed the title [skip ci] wip: markets page coingecko recommended categories [skip ci] feat: markets page recommended Sep 23, 2024
@gomesalexandre gomesalexandre changed the title [skip ci] feat: markets page recommended [skip ci] feat: markets page coingecko lists and savers recommended assets Sep 23, 2024
@gomesalexandre gomesalexandre changed the title [skip ci] feat: markets page coingecko lists and savers recommended assets feat: markets page coingecko lists and savers recommended assets Sep 23, 2024
@gomesalexandre gomesalexandre marked this pull request as ready for review September 23, 2024 18:22
@gomesalexandre gomesalexandre requested a review from a team as a code owner September 23, 2024 18:22
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very sane so far

I added a few comments mainly about avoiding duplicating constants and questions on thorchain opportunities APY shown as 0

Also noticed a few runtime things:

  • Skeletons are not following the final layout
    image

  • First asset is always using the big size while I think it should only be on the first part of the page

  • After staying for a while on the page, when reloading the page, my tab is crashing

As the last point could be a blocker for our users, blocking this PR until we investigate a bit more

Also noticed an empty page on reload at some points..

src/lib/coingecko/constants.ts Outdated Show resolved Hide resolved
src/lib/coingecko/utils.ts Show resolved Hide resolved
src/pages/Markets/Recommended.tsx Show resolved Hide resolved
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Missing an empty state when not assets returned for a chain

Is there any point to display UTXOs in the chain dropdown, even thorchain?
image

Looks like some market data are missing or takes a lot of time to load:
image

Anyway, testing on a fresh env does works like it should, all those feedbacks are not blocking this PR but it would be worth doing them in a followup because the UX would be better!

@gomesalexandre gomesalexandre merged commit 2810894 into develop Sep 25, 2024
6 checks passed
@gomesalexandre gomesalexandre deleted the feat_coingecko_recommended branch September 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markets Page - Recommended View
2 participants