fix: sell asset input loading state #7785
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
I was afraid about the accounts loading state but it seems to work pretty fine as destination asset has the skeletons
I feel like we could add a skeleton to the swapper quotes in case the users asked for quotes but accounts are loading, as a follow up maybe, wdyt?
Actual fix
Removing the skeletons works pretty fine, I have been able to enter very precise amount of ETH to swap for FOX
As the swapper has been tested while implementing these skeletons, the only specific part to test seems to be the account loading step and so it's seems happy!
lgtm! ✅
|
@NeOMakinG I don't mind your proposed follow-up at all, it would make things look a little nicer 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a UI quirk introduced in #7741, which was a little aggressive with loading states making it difficult to enter a precise input amount in the swapper.
Issue (if applicable)
Closes #7775
Risk
Low
None
Testing
When entering the sell amount of an asset, particularly the sell amount, a user should be able to do this unencumbered by loading skeletons triggered by the input itself.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
N/A