fix: fiat amount lps gas fee maths #7787
Merged
+24
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inside the validation, we are taking the minimum dust threshold in account with the gas fees, but as a presentational value, we are only displaying the gas fees without the dust threshold
This PR does add the dust threshold to the gas amount to make sure what we display is equal to the actual security check
As a followup, we might want to bring back the
0.0001
dust threshold as written in the thorchain doc: https://dev.thorchain.org/saving-guide/quickstart-guide.html#basic-mechanicsReally low deposit could be not working anymore for BTC (under around 15$ deposits), but it would permit to withdraw from the BTC pool with a smaller amount
Issue (if applicable)
closes #7778
Risk
Low
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)
For BTC, the gas fee was under 1$
Now
Other pools are sane, tested AVAX, COSMOS, FOX