Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update wallet connection splash #7793

Merged
merged 6 commits into from
Sep 25, 2024
Merged

feat: update wallet connection splash #7793

merged 6 commits into from
Sep 25, 2024

Conversation

0xApotheosis
Copy link
Contributor

@0xApotheosis 0xApotheosis commented Sep 24, 2024

Description

Updates the wallet connection splash screen to the new design.

Screenshot 2024-09-24 at 18 18 04

Issue (if applicable)

Closes #7761

Risk

Low

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None.

Testing

With the REACT_APP_EXPERIMENTAL_MM_SNAPPY_FINGERS / Snaps feature flag on, the new wallet connection UI should look like this:

Screenshot 2024-09-24 at 17 59 59

With the feature flag disabled it should look like this:

Screenshot 2024-09-24 at 18 00 10

Also ensure that the wallet connection flow works as expected.

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

See above.

@@ -178,83 +160,62 @@ export const ConnectWallet = () => {
maxWidth={maxWidth}
width={width}
>
{isMobile ? (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logical branch could never be entered, as if isMobile was true we would have early exited above.

@0xApotheosis 0xApotheosis marked this pull request as ready for review September 24, 2024 08:20
@0xApotheosis 0xApotheosis requested a review from a team as a code owner September 24, 2024 08:20
@0xApotheosis
Copy link
Contributor Author

@reallybeard this is open for review, you might want to tweak the background gradient as I had a best effort attempt at replicating the mock.

@NeOMakinG
Copy link
Collaborator

@reallybeard this is open for review, you might want to tweak the background gradient as I had a best effort attempt at replicating the mock.

Oh, I felt like this was a placeholder but wasn't intended to be changed

In this case, I think we can simply export the whole left gradient into an SVG and use it as a backgroundImage to replicate it 100% and in a safe way

@0xApotheosis
Copy link
Contributor Author

0xApotheosis commented Sep 24, 2024

@reallybeard this is open for review, you might want to tweak the background gradient as I had a best effort attempt at replicating the mock.

Oh, I felt like this was a placeholder but wasn't intended to be changed

In this case, I think we can simply export the whole left gradient into an SVG and use it as a backgroundImage to replicate it 100% and in a safe way

Yeah the ticket/mock isn't really clear. I'm also not convinced that we want to remove the ShapeShift logo entirely, but that's what the mocks seem to suggest...

Summoning @shapeshift/product.

@0xApotheosis
Copy link
Contributor Author

Also @NeOMakinG from "incorporate gradient on left" on the ticket I'm guessing it is meant to be changed!

@NeOMakinG
Copy link
Collaborator

Also @NeOMakinG from "incorporate gradient on left" on the ticket I'm guessing it is meant to be changed!

sure! It was sneaky 😆

If you want to replace it by an SVG to replicate the mockup, feel free

Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very small adjustments to align with the mockups but overall looks good

src/pages/ConnectWallet/ConnectWallet.tsx Outdated Show resolved Hide resolved
src/pages/ConnectWallet/ConnectWallet.tsx Outdated Show resolved Hide resolved
src/pages/ConnectWallet/ConnectWallet.tsx Outdated Show resolved Hide resolved
src/pages/ConnectWallet/ConnectWallet.tsx Outdated Show resolved Hide resolved
src/pages/ConnectWallet/ConnectWallet.tsx Outdated Show resolved Hide resolved
src/pages/ConnectWallet/ConnectWallet.tsx Outdated Show resolved Hide resolved
src/pages/ConnectWallet/ConnectWallet.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile with snap

image

Desktop with snap

image

Light mode

image
image

Mobile without snap

image

Desktop without snap

image

I would have expected a shapeshift logo somewhere, we totally removed our branding from the splash screen right now :(

Looks perfect anyway, nice work!

@0xApotheosis
Copy link
Contributor Author

0xApotheosis commented Sep 25, 2024

Thanks for the excellent review, @NeOMakinG!

Agree about the logo removal... @reallybeard @twblack88 are we sure we wanna drop it?

@0xApotheosis 0xApotheosis merged commit 8a1b4cb into develop Sep 25, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the new-splash branch September 25, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splash screen redux
2 participants