-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update wallet connection splash #7793
Conversation
@@ -178,83 +160,62 @@ export const ConnectWallet = () => { | |||
maxWidth={maxWidth} | |||
width={width} | |||
> | |||
{isMobile ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logical branch could never be entered, as if isMobile
was true
we would have early exited above.
@reallybeard this is open for review, you might want to tweak the background gradient as I had a best effort attempt at replicating the mock. |
Oh, I felt like this was a placeholder but wasn't intended to be changed In this case, I think we can simply export the whole left gradient into an SVG and use it as a backgroundImage to replicate it 100% and in a safe way |
Yeah the ticket/mock isn't really clear. I'm also not convinced that we want to remove the ShapeShift logo entirely, but that's what the mocks seem to suggest... Summoning @shapeshift/product. |
Also @NeOMakinG from "incorporate gradient on left" on the ticket I'm guessing it is meant to be changed! |
sure! It was sneaky 😆 If you want to replace it by an SVG to replicate the mockup, feel free |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very small adjustments to align with the mockups but overall looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the excellent review, @NeOMakinG! Agree about the logo removal... @reallybeard @twblack88 are we sure we wanna drop it? |
Description
Updates the wallet connection splash screen to the new design.
Issue (if applicable)
Closes #7761
Risk
Low
None.
Testing
With the
REACT_APP_EXPERIMENTAL_MM_SNAPPY_FINGERS
/Snaps
feature flag on, the new wallet connection UI should look like this:With the feature flag disabled it should look like this:
Also ensure that the wallet connection flow works as expected.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
See above.