feat: implement solana market data #7802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
commented
Sep 25, 2024
| @@ -44,7 +43,7 @@ export const coingeckoToAssetIds = (id: CoinGeckoId): AssetId[] => | |||
| generatedCoingeckoToAssetIdsMap[id] | |||
|
|
|||
| export const assetIdToCoingecko = (assetId: AssetId): CoinGeckoId | undefined => | |||
| generatedAssetIdToCoingeckoMap[toLower(assetId)] | |||
There was a problem hiding this comment.
I didn't see any problems with this, assetIdToCoingecko is consumed 3 time and seems ok as it is without lower case
It was breaking for the solana part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement market data for solana assets:
assetIdToCoingeckowhich is breaking for solana (this is risky)Issue (if applicable)
closes #7800
Risk
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)