fix: appcontext isSnapInstalled checks #7808
Merged
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says on the box - we were casting an object into a Boolean which means checks would always return true, and "snap just installed" checks would never evaluate to true, meaning unless you refresh the app, snap installation would never trigger non-EVM accounts derivation/fetch.
Issue (if applicable)
closes #7376
Risk
None, this was blatantly wrong
Testing
Going from uninstalled snap to installed snap derives non-EVM accounts without needing a refresh
Going from installed snap to uninstalled snap still clears accounts and trigger a refetch of EVM accounts only
In Add Accounts modal, managing non-EVM chains when having the multichain snap installed is happy
Managing accounts when not having the multichain snap installed is still disabled
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/54a6c088-a295-4111-9fe6-5d17e0efc895