Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redux-persist error spew #7824

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Sep 26, 2024

Description

Fixes a bunch of errors thrown by redux-persist after the reducers split PR.
This was caused by us using version/migrate properties but having empty lists of migrations.

Fixed by commenting out said properties for the migrations we haven't ran yet, and using version 0 instead.

Issue (if applicable)

closes N/A, spotted by big @kaladinlight

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low to none - ensure state looks good after a load of your existing state, after a full cache clear, and after a refresh

Testing

  • State looks good on your first load with existing state
  • State looks good after a cache clear
  • State looks good after a refresh of your fresh post-cache clear state

Engineering

  • ^
  • The errors in the develop screenshot are gone in the 3 scenarios mentioned above

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

  • develop
Screenshot 2024-09-26 at 23 10 28
  • this diff
Screenshot 2024-09-26 at 23 12 47

@gomesalexandre gomesalexandre requested a review from a team as a code owner September 26, 2024 21:19
src/state/reducer.ts Outdated Show resolved Hide resolved
src/state/reducer.ts Outdated Show resolved Hide resolved
@kaladinlight kaladinlight enabled auto-merge (squash) September 27, 2024 18:07
@kaladinlight kaladinlight merged commit 1704cbd into develop Sep 27, 2024
3 checks passed
@kaladinlight kaladinlight deleted the fix_redux_persist_error_spew branch September 27, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants