Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FoxIcon to ConnectWallet page #7826

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

reallybeard
Copy link
Contributor

Description

  • Add FOX icon to the splash page
  • Update sidebar background with a slightly different one

Issue (if applicable)

closes #

Risk

High Risk PRs Require 2 approvals

low risk

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

On the connect wallet page, you will see the fox icon at the top.

Screenshots (if applicable)

Screenshot 2024-09-26 at 5 41 22 PM

@reallybeard reallybeard requested a review from a team as a code owner September 26, 2024 22:42
@twblack88
Copy link
Contributor

twblack88 commented Sep 26, 2024

Fixes #7823 , however.....

Screenshot 2024-09-26 at 3 44 44 PM

FWIW, @reallybeard the breakpoints on the more chonky screen like a laptop totally messed with the gradient sizing. Cutting off the bottom looks like just blue screen of death. I think the logo and the new colors fix but....could be wrong.

Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the blue sidebar looks awful, but I'm not the designer - code-wise this is fine.

@0xApotheosis 0xApotheosis merged commit 9811910 into develop Sep 26, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the add-logo-to-splash branch September 26, 2024 23:03
@twblack88
Copy link
Contributor

Yeah, that's fair, still trying to figure out the new branding assets. Probably needs another pass for tweaks and more luster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants