Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize packages #7828

Merged
merged 1 commit into from
Sep 27, 2024
Merged

chore: optimize packages #7828

merged 1 commit into from
Sep 27, 2024

Conversation

0xApotheosis
Copy link
Contributor

Description

  • Removes unused packages
  • Moves eslint-plugin-react-memo to devDependencies as it's unneeded at runtime

Issue (if applicable)

Housekeeping, loosly related to #7768

Risk

Small

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

The app should operate just as it already does, with no regressions.

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

N/A

@0xApotheosis 0xApotheosis requested a review from a team as a code owner September 27, 2024 01:53
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, optimization LGTM!

  • Confirmed dev build is still happy
  • Confirmed react-memo/require-usememo lint violations are still caught
  • Confirmed built build is still happy

Get in :fridaydog:

@gomesalexandre gomesalexandre merged commit 9b743da into develop Sep 27, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the optimize-packages branch September 27, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants