chore: minor changes to thorchain swapper tx status during swaps #7830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodenfurniture
commented
Sep 28, 2024
| @@ -373,7 +373,7 @@ export const thorchainApi: SwapperApi = { | |||
| } | |||
|
|
|||
| const latestOutTx = data.out_txs?.[data.out_txs.length - 1] | |||
| const hasOutboundTx = latestOutTx?.chain !== 'THOR' | |||
| const hasOutboundTx = latestOutTx !== undefined && latestOutTx.chain !== 'THOR' | |||
There was a problem hiding this comment.
So turns out, if there is no latestOutTx it means it doesn't actually have an outbound tx 😅
|
Closed in favor of #7831 |
0xApotheosis
approved these changes
Sep 30, 2024
| @@ -61,15 +61,18 @@ export const getLatestThorTxStatusMessage = ( | |||
| } | |||
| } | |||
|
|
|||
| return { message: obj.pending ? 'Swap pending' : 'Swap complete', status: TxStatus.Pending } | |||
| return { | |||
| message: obj.pending ? 'Swap pending' : 'Swap complete, awaiting finalization', | |||
There was a problem hiding this comment.
Not for this PR at all, but it occurred to me whilst reading this that all of these probably need actual translations!
|
The ruggiest of rugs 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Investigation of #7371 led to some improvements to copy and a fix to swap status logic. Huzzah.
Issue (if applicable)
Stemmed from investigation of #7371
Risk
Low risk.
Testing
Test thorchain swaps complete as expected with better copy.
Engineering
Operations
Screenshots (if applicable)