Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solana standard tx parsing #7924

Merged
merged 4 commits into from
Oct 15, 2024
Merged

feat: solana standard tx parsing #7924

merged 4 commits into from
Oct 15, 2024

Conversation

kaladinlight
Copy link
Contributor

Description

Solana unchained-client support (parser and api client)

Issue (if applicable)

closes #7738

Risk

High Risk PRs Require 2 approvals

Low - behind feature flag and only basic send/receive sol support (no spl tokens)

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Unit tests should work

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

N/A

Screenshots (if applicable)

@kaladinlight kaladinlight requested a review from a team as a code owner October 11, 2024 18:48
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one query about the confirmations.

@0xApotheosis 0xApotheosis self-assigned this Oct 14, 2024
@NeOMakinG
Copy link
Collaborator

@kaladinlight seems very sane to me, I could stamp it but when do we plan to parse the SPL Tokens transfers? We would need to create an issue or plan the follow up so we don't lose track

@kaladinlight
Copy link
Contributor Author

@kaladinlight seems very sane to me, I could stamp it but when do we plan to parse the SPL Tokens transfers? We would need to create an issue or plan the follow up so we don't lose track

Was starting with standard send full implementation first and then following up with tokens. Will fall into this guy: #7903. I will update to be more generic

Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversation around confirmations is only a nitpick, and not worth holding this PR up for - let's get 'er in!

@0xApotheosis 0xApotheosis merged commit c542ca2 into develop Oct 15, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the solana-parser branch October 15, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solana Prep - TX Parsers
3 participants