Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add limit order view UI #8020

Merged
merged 17 commits into from
Oct 29, 2024
Merged

feat: add limit order view UI #8020

merged 17 commits into from
Oct 29, 2024

Conversation

0xApotheosis
Copy link
Contributor

@0xApotheosis 0xApotheosis commented Oct 29, 2024

Description

Adds UI for viewing open and completed limit orders.

Note for reviewer:

  • This PR uses mock data only
  • I need to tweak the AssetIconWithBadge component to properly handle the use case (follow-up PR), and so it's currently hardcoded to the Ethereum icon for mock purposes
  • This PR does not yet handle smaller viewports, only the expanded version

Issue (if applicable)

Contributes to #6206

Risk

High Risk PRs Require 2 approvals

Small, all changes are behind a flag and visible only on the Limit tab.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

Ensure when clicking the limit tab the OrdersList component opens automatically, and matches the mocks.

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Screenshot 2024-10-29 at 12 31 27 Screenshot 2024-10-29 at 12 31 44

@0xApotheosis 0xApotheosis requested a review from a team as a code owner October 29, 2024 01:37
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking super tasty, with just a couple minor comments to re-use things and translate stuff where we can 🎉

Q: Is the layout for narrow screens implemented yet, or is out of scope? Currently on narrow screens it doesnt show the order view button and is far left:

Non-blocking (since this is all WIP): Need to be able to scroll the orders list

@0xApotheosis
Copy link
Contributor Author

Q: Is the layout for narrow screens implemented yet, or is out of scope? Currently on narrow screens it doesnt show the order view button and is far left

Indeed, that was not intended for this PR 🙏 "This PR does not yet handle smaller viewports, only the expanded version".

Non-blocking (since this is all WIP): Need to be able to scroll the orders list

Good catch, I'll address this in the next PR.

Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few non-blocking comments and 1 seemingly missed blocking one

Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getitin

@0xApotheosis 0xApotheosis enabled auto-merge (squash) October 29, 2024 22:17
@0xApotheosis 0xApotheosis merged commit 386e795 into develop Oct 29, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the limit-order-list branch October 29, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants