fix: upsert account on new tx #8031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Arb
https://jam.dev/c/25ba2d76-9709-4093-866e-57c2fcaf13c3
Solana is failing
https://jam.dev/c/225b0b2a-8c96-457e-94b6-2a534d1a9a3f
But I think it's expected, do we have a known issue about Solana's websockets?
THORChain/COSMOS
https://jam.dev/c/6a941739-6363-48c0-b65a-2da8b136f573
Most websockets seems like working as usually, as the issue was on web side, but solana's websocket did fail, unrelated to this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upsert account on new tx detected via websockets. Regression from #7822. Currently we don't update portfolio when transactions are detected after broadcast requiring the user to refresh the app to get accurate balance updates.
Issue (if applicable)
closes #8008
Risk
Low
Testing
Engineering
☝️
Operations
☝️
Screenshots (if applicable)