fix: lifi fees same as shapeshift fees #8037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Li.Fi fees returned from the
routes
endpoint is returning aLIFI Shared Fee
fees step which is the total affiliate feesThey share a part of these affiliate fees but I couldn't find a way to get how much they share, I asked on their discord (https://discord.com/channels/849912621360218112/1108511354253475872/1300968397336743936) and I'm waiting for an answer
During that time as we show double fees to our user, I did skip this step and only show ShapeShift fees which may be true but also wrong if Li.Fi take some fees from this amount
Issue (if applicable)
closes #7987
Risk
Medium, mainly presentational but could show wrong fees to users
Testing
not
be equal to the ShapeShift fees.Engineering
n/a
Operations
n/a
Screenshots (if applicable)
One hop on arb:
Swap with relayer fees: