Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lifi fees same as shapeshift fees #8037

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

NeOMakinG
Copy link
Collaborator

Description

Li.Fi fees returned from the routes endpoint is returning a LIFI Shared Fee fees step which is the total affiliate fees

They share a part of these affiliate fees but I couldn't find a way to get how much they share, I asked on their discord (https://discord.com/channels/849912621360218112/1108511354253475872/1300968397336743936) and I'm waiting for an answer

During that time as we show double fees to our user, I did skip this step and only show ShapeShift fees which may be true but also wrong if Li.Fi take some fees from this amount

Issue (if applicable)

closes #7987

Risk

Medium, mainly presentational but could show wrong fees to users

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Try a route with Li.Fi (ETH on Arb to FOX on Arb), it shouldn't show the Protocol Fees as this step contains only one protocol fee step which is the affiliate rates
  • Try a bigger route like ETH on Arb to FOX on Ethereum, this route should display some protocol fees which is equal to the relayer this and should absolutely not be equal to the ShapeShift fees.

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

One hop on arb:
image

Swap with relayer fees:
image

@NeOMakinG NeOMakinG requested a review from a team as a code owner October 29, 2024 23:48
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Confirmed with @shapeshift/product this is the correct intent
  • Confirmed the fee used as heuristics is the one we want to remove
image
  • Confirmed the fee is gone from protocol fees
image

@gomesalexandre gomesalexandre enabled auto-merge (squash) October 30, 2024 00:47
@gomesalexandre gomesalexandre merged commit e1545ca into develop Oct 30, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the protocol-fee-shapeshift branch October 30, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocol fee for Lifi and Portals trades seems to be the same as the shapeshift fee
2 participants