Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented ui state management in limit orders input #8041

Merged
merged 3 commits into from
Oct 30, 2024
Merged

feat: implemented ui state management in limit orders input #8041

merged 3 commits into from
Oct 30, 2024

Conversation

woodenfurniture
Copy link
Member

Description

Adds some state management to the limit orders input, in prep for making requests to the RTK query.

This is an incremental change intended to minimise review surface area/noise, and increase focus on important changes once RTK query is wired up.

  • Adds translations where needed
  • Implements the ridiculous logic on input handling for limit price, combined with preset values etc

Issue (if applicable)

progresses #8032

Risk

High Risk PRs Require 2 approvals

Low risk.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Not required at this stage.

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Quick demo of the clicky fun times.
https://jam.dev/c/fb7ae4d3-9124-47a1-87f8-af2fa5b39afb

@woodenfurniture woodenfurniture requested a review from a team as a code owner October 30, 2024 01:24
gomesalexandre
gomesalexandre approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No testy = get in for the sake of progression ser!

0xApotheosis
0xApotheosis approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking tasty. Quick sanity check, custom limit amount now active 👌

@woodenfurniture woodenfurniture force-pushed the limit-orders-input-state-management branch from 70d7d48 to a2de479 Compare October 30, 2024 22:18
@woodenfurniture woodenfurniture enabled auto-merge (squash) October 30, 2024 22:19
@woodenfurniture woodenfurniture merged commit e833368 into develop Oct 30, 2024
3 checks passed
@woodenfurniture woodenfurniture deleted the limit-orders-input-state-management branch October 30, 2024 22:26
@0xApotheosis 0xApotheosis mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woodenfurniture @gomesalexandre @0xApotheosis