Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add supported solana assets to banxa and onramper #8046

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kaladinlight
Copy link
Contributor

Description

Add supported solana assets to banxa and onramper

Issue (if applicable)

closes #8015

Risk

High Risk PRs Require 2 approvals

Low

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Ensure supported solana assets are listed under buy/sell crypto
  • Ensure you can interacted with the supported providers

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

image
image
image

@kaladinlight kaladinlight requested a review from a team as a code owner October 30, 2024 18:33
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm

Screenshot 2024-10-31 at 06 56 56 Screenshot 2024-10-31 at 06 57 07 Screenshot 2024-10-31 at 06 57 17 Screenshot 2024-10-31 at 06 58 10

@0xApotheosis 0xApotheosis merged commit 963ef57 into develop Oct 30, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the solana-fiat-providers branch October 30, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SOL balance not detected in Fiat provider list as available asset to sell/buy
2 participants